Skip to content

CogwheelChainBehaviour#tryTransferOnRemoval getControlledChain nullpointer case #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pucgenie wants to merge 3 commits into
base: main
Choose a base branch
from
Open

CogwheelChainBehaviour#tryTransferOnRemoval getControlledChain nullpointer case #153

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7c1b1a0
CogwheelChainBehaviour#tryTransferOnRemoval getControlledChain nullpo…
pucgenie Aug 11, 2026
2187b29
fix missing java.util.Optional import
pucgenie Aug 11, 2026
ecdcf31
fix missing java.util.Optional value get
pucgenie Aug 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .../java/com/kipti/bnb/content/kinetics/cogwheel_chain/behaviour/CogwheelChainBehaviour.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,9 +159,10 @@ private boolean tryTransferOnRemoval() {
if (controllerBehaviour == null) return false;

final BlockState replacingState = this.getLevel().getBlockState(this.getPos());
final PathedCogwheelNode thisNode = controllerBehaviour.getControlledChain().getNodeFromControllerOffset(
// getControlledChain() may return null. pucgenie: idk why exactly, but it really happens in skies2 aero 1.6.0 https://mclo.gs/Oce6yL8
final PathedCogwheelNode thisNode = java.util.Optional.ofNullable(controllerBehaviour.getControlledChain()).map(controlledChain -> controlledChain.getNodeFromControllerOffset(
this.controllerOffset == null ? Vec3i.ZERO : this.controllerOffset
);
)).orElse(null);
final CogwheelChainCandidate replacingCandidate = CogwheelChainCandidate.getForBlock(replacingState);
if (replacingCandidate == null || thisNode == null ||
!replacingCandidate.isConsistentWithNode(thisNode) ||
Expand Down