Eric-s-s orig #1107
Closed
Eric-s-s orig #1107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i looked through it twice. it looks correct. the latest commit with your requested changes is there, and on two look throughs i believe everything else is there. does that travis-ci fail on a hypothesis test have anything to do with this code, or is that a separate issue? |
I've reset that build. I expect it's nothing to do with your code. Can you or @marcharper offer some guidance, what should we be doing with this PR versus #1106 and #1092? |
|
i just tried resetting, re-rebasing and force pushing in #1092. if that worked, i vote to merge that and close this. if it didn't work, then i'd vote to merge this and close that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.