Fix IME client incorrectly handling child control events#590
Closed
Timskt wants to merge 1 commit into
Closed
Conversation
The TextInputMethodClientRequestedEvent handler was capturing events from child controls (e.g. search TextBox), preventing them from properly setting up their own IME clients. Add an e.Source == ta check to only handle IME for the TextArea itself. Fixes the issue described in #532.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
TextInputMethodClientRequestedEventhandler inTextAreawas capturing events from child controls (e.g. search TextBox), preventing them from properly setting up their own IME clients.This fix adds an
e.Source == tacheck to only handle IME for the TextArea itself, matching the behavior expected when child controls like the search panel's TextBox need independent IME support.Changes
TextArea.cs: Addede.Source == tacondition to theTextInputMethodClientRequestedEventhandlerRelated
Test plan