Skip to content

Conversation

@valterlorran
Copy link
Contributor

Part of #

Proposed Changes

  • Fixes the copy button border. The border should not have a border.

Before

Captura de Tela 2025-11-14 às 12 44 28

After

Captura de Tela 2025-11-14 às 12 45 17

Why are these changes being made?

  • On production, the copy button would have an unexpected border.

Testing Instructions

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you tested accessibility for your changes? Ensure the feature remains usable with various user agents (e.g., browsers), interfaces (e.g., keyboard navigation), and assistive technologies (e.g., screen readers) (PCYsg-S3g-p2).
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@valterlorran valterlorran requested a review from Copilot November 14, 2025 15:50
@valterlorran valterlorran self-assigned this Nov 14, 2025
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Nov 14, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a styling issue where the copy button in the SSH Migration share access step had an unexpected border on production. The fix moves the border: none declaration from a general style rule to a more specific selector that includes the is-transparent class modifier.

  • Replaced the general border: none rule with a more specific &.button.is-transparent selector to ensure proper CSS specificity

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +252 to +254
&.button.is-transparent {
border: none;
}
Copy link

Copilot AI Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The border: none declaration appears redundantly in both the new &.button.is-transparent block (lines 252-254) and the existing hover/focus/active states block (line 248). Consider consolidating these rules by moving &.button.is-transparent above the hover states and applying border: none once, or ensuring the specificity increase is intentional to override external styles.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants