Skip to content

Plugins redesign: Fix Server Side Rendering for the Dot Pager #107132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from
+8 −15
Open

Plugins redesign: Fix Server Side Rendering for the Dot Pager #107132

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
385203d
Check for the document object before using it
claudiucelfilip Nov 14, 2025
8925223
Repalce use-subscribe with native React equivalent
claudiucelfilip Nov 14, 2025
53f3867
Undo dependencies change
claudiucelfilip Nov 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/components/src/swipeable/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,6 +265,9 @@ export const Swipeable = ( {
);

const getTouchEvents = useCallback( () => {
if ( typeof document === 'undefined' ) {
return null;
}
if ( 'onpointerup' in document ) {
return {
onPointerDown: handleDragStart,
Expand Down
20 changes: 5 additions & 15 deletions packages/i18n-calypso/src/rtl.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,24 +1,14 @@
import { createHigherOrderComponent } from '@wordpress/compose';
import { forwardRef, useContext, useMemo } from 'react';
import { useSubscription } from 'use-subscription';
import { forwardRef, useCallback, useContext, useSyncExternalStore } from 'react';
import I18NContext from './context';

export function useRtl() {
const i18n = useContext( I18NContext );
// Subscription object (adapter) for the `useSubscription` hook
const RtlSubscription = useMemo(
() => ( {
getCurrentValue() {
return i18n.isRtl();
},
subscribe( callback ) {
return i18n.subscribe( callback );
},
} ),
[ i18n ]
);

return useSubscription( RtlSubscription );
const getSnapshot = useCallback( () => i18n.isRtl(), [ i18n ] );
const subscribe = useCallback( ( callback ) => i18n.subscribe( callback ), [ i18n ] );

return useSyncExternalStore( subscribe, getSnapshot, getSnapshot );
}

export const withRtl = createHigherOrderComponent(
Expand Down
Loading