Skip to content

Conversation

@gabrielcaires
Copy link
Contributor

Close CML-1036

Proposed Changes

  • Make the discover menu selected when the user navigates to any /discover/* section.

Why are these changes being made?

  • User will be more aware of where they are

Testing Instructions

  • Go to discover
  • Check if the menu item is selected
  • Go to any internal tab (Recommended, First Posts, Latests, etc...)
  • Check the discovered item is still selected
CleanShot 2025-11-14 at 11 57 17@2x

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you tested accessibility for your changes? Ensure the feature remains usable with various user agents (e.g., browsers), interfaces (e.g., keyboard navigation), and assistive technologies (e.g., screen readers) (PCYsg-S3g-p2).
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@gabrielcaires gabrielcaires marked this pull request as ready for review November 14, 2025 11:58
@gabrielcaires gabrielcaires requested a review from a team as a code owner November 14, 2025 11:58
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 14, 2025
@github-actions
Copy link

github-actions bot commented Nov 14, 2025

@matticbot
Copy link
Contributor

matticbot commented Nov 14, 2025

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/keep-menu-item-selected on your sandbox.

Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests well 🚢

@jeherve jeherve added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Nov 17, 2025
@gabrielcaires gabrielcaires merged commit 7bd94d4 into trunk Nov 17, 2025
12 checks passed
@gabrielcaires gabrielcaires deleted the fix/keep-menu-item-selected branch November 17, 2025 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants