Skip to content

Conversation

@keoshi
Copy link
Contributor

@keoshi keoshi commented Nov 14, 2025

Proposed Changes

  • Adds class to formattedContent on Activity logs

Why are these changes being made?

Testing Instructions

  • Fire up this PR.
  • Visit Dashboard v2 and go into Activity logs.
  • Ensure that the description of the events have an associated site-activity-logs__event-description class.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you tested accessibility for your changes? Ensure the feature remains usable with various user agents (e.g., browsers), interfaces (e.g., keyboard navigation), and assistive technologies (e.g., screen readers) (PCYsg-S3g-p2).
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@keoshi keoshi requested a review from andrea-sdl November 14, 2025 07:20
@keoshi keoshi self-assigned this Nov 14, 2025
@keoshi keoshi requested a review from a team as a code owner November 14, 2025 07:20
@keoshi keoshi added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. Activity Log [Feature] Multi-site Dashboard labels Nov 14, 2025
@github-actions
Copy link

github-actions bot commented Nov 14, 2025

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • help-center

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/activity-log-formattedContent-class on your sandbox.

Copy link
Contributor

@andrea-sdl andrea-sdl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected, thanks for caring about consistency! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Activity Log [Feature] Multi-site Dashboard [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants