Skip to content

Conversation

@fushar
Copy link
Contributor

@fushar fushar commented Nov 14, 2025

Fixes CHE-258

Proposed Changes

Add persistence support in billing history DataViews.

Also renamed some variables / functions to align better with existing pattern in the dashboard code.

Testing Instructions

  1. Go to /v2/me/billing/billing-history.
  2. Try to update appearance options (density, page size, etc.)
  3. Refresh the page.
  4. Verify the config is retained.

Important

If the view is modified, then the automatic field adjustment based on screen width no longer takes effect. It seems, we need to address this more holistically upstream. See this discussion: p1761735187809839/1760623861.876189-slack-C05QAFZSFTL

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you tested accessibility for your changes? Ensure the feature remains usable with various user agents (e.g., browsers), interfaces (e.g., keyboard navigation), and assistive technologies (e.g., screen readers) (PCYsg-S3g-p2).
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@github-actions
Copy link

github-actions bot commented Nov 14, 2025

@fushar fushar self-assigned this Nov 14, 2025
@fushar fushar marked this pull request as ready for review November 14, 2025 04:25
@fushar fushar requested review from a team as code owners November 14, 2025 04:25
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 14, 2025
Copy link
Member

@sirbrillig sirbrillig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described! I also tested it on top of #107105 and it preserves the page number when navigating to the receipt view and back via breadcrumbs. Nice work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants