Skip to content

Conversation

@fushar
Copy link
Contributor

@fushar fushar commented Nov 14, 2025

Resolves #107032 (comment)

Proposed Changes

Fixes this card in domain overview when that domain has no emails yet:

image

BEFORE

Click on that card.

Land on Emails page with empty list and broken filter:

image

Click on the Add mailbox button at the top right.

Land in email registration flow:

image

Choose EXACTLY THE SAME DOMAIN as you started with.

... finally you can add mailbox:

image

AFTER

You land directly on the last screen.

OUT OF SCOPE

The <- Emails back button still points to /v2/emails 🥹 seems we need a better solution for handling this scenario. I'm marking this as out of scope of this PR, unless anyone feels strongly. I don't know a good solution for this.

Why are these changes being made?

The existing flow is confusing.

Testing Instructions

Test the scenario as described above.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you tested accessibility for your changes? Ensure the feature remains usable with various user agents (e.g., browsers), interfaces (e.g., keyboard navigation), and assistive technologies (e.g., screen readers) (PCYsg-S3g-p2).
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@github-actions
Copy link

github-actions bot commented Nov 14, 2025

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • help-center

To test WordPress.com changes, run install-plugin.sh $pluginSlug domain-no-emails-upsell on your sandbox.

@fushar fushar requested a review from a team November 14, 2025 02:47
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 14, 2025
@fushar fushar marked this pull request as ready for review November 14, 2025 02:48
@fushar fushar requested a review from a team as a code owner November 14, 2025 02:48
Copy link
Member

@m1r0 m1r0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks for fixing it! It works as described.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants