Skip to content

Conversation

@tiagonoronha
Copy link
Contributor

@tiagonoronha tiagonoronha commented Nov 13, 2025

Related to https://linear.app/a8c/issue/A4A-1609/woopayments-commission-eligibility-label-is-not-matching-site

Proposed Changes

  • Update status popover to show specific ineligibility reason when available
  • Allow customization of the link and link text per ineligible reason
  • Maps error codes to user-friendly messages
Screenshot 2025-11-13 at 15 57 31

Why are these changes being made?

  • Agencies often struggle to understand why a site isn’t eligible. These changes will help add clear ineligibility reasons to the Agencies dashboard.

Testing Instructions

  • Apply 195963-ghe-Automattic/wpcom to your sandbox if not merged yet.
  • Refer to the WPCOM PR above for test agency details.
  • Open the live link and go to /woopayments/dashboard
  • Hover the "Not eligible" badge and confirm it displays one of the custom messages add in this PR (see the PR changes)

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you tested accessibility for your changes? Ensure the feature remains usable with various user agents (e.g., browsers), interfaces (e.g., keyboard navigation), and assistive technologies (e.g., screen readers) (PCYsg-S3g-p2).
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@github-actions
Copy link

github-actions bot commented Nov 13, 2025

@tiagonoronha tiagonoronha requested a review from a team November 13, 2025 17:23
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 13, 2025
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • help-center

To test WordPress.com changes, run install-plugin.sh $pluginSlug a4a/woopayments/ineligile-reason on your sandbox.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants