Skip to content

Conversation

alshakero
Copy link
Member

@alshakero alshakero commented Jun 6, 2025

Proposed Changes

Visual improvements to the Help Card in the My Home Page.

Why are these changes being made?

Aesthetic value.

Testing Instructions

  1. Go to my home.
  2. Scroll down.
  3. Play with the Help Card.

Screenshots

Before After
image image

Copy link

github-actions bot commented Jun 6, 2025

@alshakero alshakero added the [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging label Jun 6, 2025
@alshakero alshakero requested a review from a team June 6, 2025 17:48
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jun 6, 2025
@alshakero alshakero requested a review from fditrapani June 6, 2025 17:49
@alshakero alshakero changed the title Implement changes Customer Home Help Card: Improve Design Jun 6, 2025
@matticbot
Copy link
Contributor

matticbot commented Jun 6, 2025

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • help-center

To test WordPress.com changes, run install-plugin.sh $pluginSlug dotsup-51-enhance-my-home-get-help-card-clarity on your sandbox.

@matticbot
Copy link
Contributor

matticbot commented Jun 6, 2025

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~31 bytes added 📈 [gzipped])

name  parsed_size           gzip_size
home        +43 B  (+0.0%)      +31 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@a8ci18n
Copy link

a8ci18n commented Jun 6, 2025

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17540950

Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday.

Thank you @alshakero for including a screenshot in the description! This is really helpful for our translators.

@fditrapani
Copy link
Contributor

Thanks for working on this. Looks great. I have some minor feedback:

It looks like we have extra spacing after the recommended resources:

image

There is nested padding on some of the elements within that section. Removing it will tighten things up a bit:

image

On mobile, the section gets lost or feels detached from the help section:

image

Can we update the border so it appears after the content:

image

@alshakero
Copy link
Member Author

@fditrapani addressed!

Copy link
Member

@mmtr mmtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This tests well for me!

@escapemanuele
Copy link
Contributor

Nice change 👌

@alshakero alshakero merged commit 9620937 into trunk Jun 9, 2025
11 checks passed
@alshakero alshakero deleted the dotsup-51-enhance-my-home-get-help-card-clarity branch June 9, 2025 13:19
@github-actions github-actions bot removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging labels Jun 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants