Skip to content

Accessibility: add ARIA labels to Add New Site dialog #104039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from

Conversation

gcsecsey
Copy link
Contributor

@gcsecsey gcsecsey commented Jun 6, 2025

Fixes DOTCOM-13537 Improve VoiceOver labels on 'Add new site' dialog

Proposed Changes

  • Add aria-labels to all MenuItem components in the Add New Site dialog

Why are these changes being made?

Improve the accessibility for VoiceOver users. Having the rendered labels announced might not make the options clear enough.

Testing Instructions

  • Pull the changes from this branch or use the Calypso Live Link
  • Go to /sites and click the "Add Site" button to open the dialog
  • Enable VoiceOver
  • Use the Control + Option + Arrow keys or the Tab key to navigate between the options
  • Check that each option is announced with its new, more descriptive label
  • Check that visual labels remain unchanged
CleanShot.2025-06-06.at.15.20.51.mp4

@gcsecsey gcsecsey requested a review from a team June 6, 2025 14:30
@gcsecsey gcsecsey requested a review from a team as a code owner June 6, 2025 14:30
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jun 6, 2025
Copy link

github-actions bot commented Jun 6, 2025

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • help-center
  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug dotcom-13537-improve-voiceover-labels-on-add-new-site-dialog on your sandbox.

@matticbot
Copy link
Contributor

matticbot commented Jun 6, 2025

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Async-loaded Components (~82 bytes added 📈 [gzipped])

name                                             parsed_size           gzip_size
async-load-calypso-dashboard-sites-add-new-site       +370 B  (+5.1%)      +82 B  (+3.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@ivan-ottinger ivan-ottinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! The changes look good and work as expected. 👌🏼 Approving!


One additional thing we could consider is to update how the "Get a free domain [...]" link on the side is read. At the moment there's a lot of redundancy:

Markup on 2025-06-06 at 16:45:53

@gcsecsey
Copy link
Contributor Author

gcsecsey commented Jun 6, 2025

Nice! The changes look good and work as expected. 👌🏼 Approving!

One additional thing we could consider is to update how the "Get a free domain [...]" link on the side is read. At the moment there's a lot of redundancy:

Markup on 2025-06-06 at 16:45:53

That's a good point @ivan-ottinger, thanks for highlighting! 👍 I added labels to this link as well:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants