-
Notifications
You must be signed in to change notification settings - Fork 72
Add feature flag and backend support for additional dispute evidence types #11129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add feature flag and backend support for additional dispute evidence types #11129
Conversation
… and update related unit tests
025eb9e to
b6b88c8
Compare
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: 0 B Total Size: 874 kB ℹ️ View Unchanged
|
…ew-challenge-forms
frosso
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I like the addition of the tests as well 👍 just a minor note on the naming in the tests.
Fixes #WOOPMNT-5447
Adds backend support for new dispute evidence form types (Event, Booking/Reservation, Other) as part of the "Improve the WooPayments Dispute Experience" initiative.
This PR introduces a new feature flag
DISPUTE_ADDITIONAL_EVIDENCE_TYPESand implements booking product type auto-detection, enabling merchants to submit more specific evidence based on their product type.Product Types Supported
After this change, the backend will support 7 product types for dispute challenges:
physical_product(existing)digital_product_or_service(existing)offline_service(existing)multiple(existing)event(new - manual selection only)booking_reservation(new - auto-detected for booking products when flag is ON)other(new - manual selection only)Changes proposed in this Pull Request
DISPUTE_ADDITIONAL_EVIDENCE_TYPES(disabled by default)determine_suggested_product_type()booking_reservationtypedigital_product_or_serviceorphysical_product)Key Decisions
Testing instructions
Prerequisites
Manual Testing (Optional - can be properly tested after frontend is ready)
Test Case 1: Booking Product → booking_reservation
Enable the feature flag via:
wp option update _wcpay_feature_dispute_additional_evidence_types 1- Go to Products → Add New
- Product name: "Hotel Room Booking"
- Product type: Select "Bookable product"
- Set price: $100
- Configure booking settings (duration, availability, etc.)
- Publish
- Add the bookable product to cart
- Proceed to checkout
- Use Stripe test card: 4000000000000259 (dispute-able card)
- Complete the order
- Go to Payments → Disputes
- Locate the payment you just created and click Respond
- Click Challenge Dispute
- In the browser dev tools check the dispute request: wc/v3/payments/disputes/du_12345
- In the response, verify
order.suggested_product_typeisbooking_reservationTest Case 2: Flag OFF → fallback behavior
wp option update _wcpay_feature_dispute_additional_evidence_types 0
order.suggested_product_typeisphysical_product(previous default)npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge