Fix WooPay express button text clipping #11126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
Contributor
|
Size Change: +468 B (0%) Total Size: 874 kB
ℹ️ View Unchanged
|
Contributor
|
@mgascam is there something specific needed to see the Before state? I tried in Safari and Chrome/Arc, and both
develop.movThis branch: this-branch.mov |
frosso
approved these changes
Nov 10, 2025
Contributor
frosso
left a comment
frosso
left a comment
There was a problem hiding this comment.
I was able to reproduce the before / after, and test the fix on multiple pages & with mutiple styles/sizes. Changes look good to me. I considered to make a suggestion and creating a SCSS mixin as below, but I think it would have become a little less maintainable.
@mixin responsive-container-queries($size-offset: 0) {
@container woopay-button (max-width: 280px) {
font-size: #{14 + $size-offset}px;
letter-spacing: #{0.5 + ($size-offset * 0.1)}px;
svg {
width: #{88 + $size-offset}px;
margin-left: 4px;
}
}
@container woopay-button (max-width: 240px) {
font-size: #{12 + $size-offset}px;
letter-spacing: #{0.3 + ($size-offset * 0.1)}px;
svg {
width: #{84 + $size-offset}px;
margin-left: 3px;
}
}
@container woopay-button (max-width: 200px) {
font-size: #{10 + $size-offset}px;
letter-spacing: #{0.2 + ($size-offset * 0.1)}px;
svg {
width: #{80 + $size-offset}px;
margin-left: 2px;
}
}
}In the end, the outputted code wouldn't really change in lenght. So this is good to me 👍
Contributor
|
@RadoslavGeorgiev I think you might need to change the WooPay CTA's value from "Only icon" to something else 
|
RadoslavGeorgiev
approved these changes
Nov 10, 2025
. With multiple screen sizes and browsers, I couldn't break this. It's the resilience that the button needed.
…-cutoff-on-checkout-alt
mgascam
deleted the
woopmnt-5396-woopay-pill-shaped-button-is-cutoff-on-checkout-alt
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #WOOPMNT-5396
This PR fixes the WooPay express checkout button text clipping issue that occurred when buttons were displayed horizontally in constrained layouts (e.g., checkout block with multiple payment buttons).
Changes proposed in this Pull Request
Solutions considered:
Trade-offs:
Screenshots
Before
After
Testing instructions
Tested the button size and call to action variations on Chrome, Safari and Firefox and Mobile Safari.
Prerequisites:
Expected result:
No text or logo clipping at any viewport size or button configuration.
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge