Updates to allow passing notification communications email to server. #11102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
Contributor
|
Size Change: +628 B (0%) Total Size: 874 kB
ℹ️ View Unchanged
|
elazzabi
approved these changes
Oct 27, 2025
Member
elazzabi
left a comment
elazzabi
left a comment
There was a problem hiding this comment.
Pre-approving, as this works as expected.
My only review is the length of the input, as I think it should match the others.
Contributor
Author
|
Hi @rogermattic - I need a design check on this to make sure it makes sense from a Design POV 🙂 are you able to take a look, or let me know who the best person to ask is? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5379
Changes proposed in this Pull Request
Adds a new "Notifications" section to the WooPayments settings page, allowing merchants to specify a communications email address for receiving WooPayments-related notifications. This email is preferred when delivering WooPayments related communications.
Testing instructions
Prerequisites
Check out the associated server PR which adds support for this field (ask on Slack 🙂 )
npm run watchto build the JS.Screenshots
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge