removed type='text/javascript' to pass HTML5 #193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
type='text/javascript' will trigger warnings for HTML5 validation, type it's deprecated and should be removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
type='text/javascript' will trigger warnings for HTML5 validation, type it's deprecated and should be removed.
Fixes #
Change in syntaxhighlighter.php line 940 from <script type='text/javascript'> to <script>.
There are two places where syntaxhighlighter.php will include the script tag with the deprecated attribute, but the first one is for the admin interface so is less important but the one on 940, will echo the script to the frontend, where is more important for the DOM to pass validation.
Deprecated Code
type='text/javascript'