Only apply markdown decorations when the note has markdown enabled#3408
Open
gunjanjaswal wants to merge 3 commits into
Open
Only apply markdown decorations when the note has markdown enabled#3408gunjanjaswal wants to merge 3 commits into
gunjanjaswal wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3379.
Markdown decorations (headings, bold, italic, list markers, and so on) were applied in the editor even when the note had Markdown disabled. Every other Markdown behavior in
note-content-editor.tsxgates on the note'smarkdownsystem tag, but the decoration path insetDecoratorsdid not, so a plain note with a line like# commentor*.confstill got heading/emphasis styling. This is the v2.26.0 regression reported in #3379.Changes proposed
markdown-decorations.ts:getMarkdownDecorationsnow takes amarkdownEnabledflag (defaults totrue) and returns[]when it is false.note-content-editor.tsx: passnote.systemTags.includes('markdown'). The existingclear()stays unconditional, so decorations are removed when Markdown is toggled off on an open note.markdown-decorations.test.ts: add a case asserting no decorations are returned when markdown is disabled.Testing instructions
npx jest lib/markdown-decorations.test.tsOr manually: open a note with Markdown disabled and a body containing
# headingor**bold**, confirm the text stays plain, then toggle Markdown on and confirm the styling appears.