[New Onboarding] Encoure acount creation update for new onboarding #3508
+9
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergioEstevao
requested review from
danielebogo
and removed request for
a team
danielebogo
requested changes
Sep 21, 2025
There was a problem hiding this comment.
Hey @SergioEstevao , following your steps I was able to see the Informational View.
I left one comment and a question, and found a UI problem with the new font sizes on smaller devices
|
|
||
| if FeatureFlag.encourageAccountCreation.enabled, | ||
| !Settings.hasShownInformationalViewModal, | ||
| Settings.hasSeenInitialOnboardingBefore == true, |
There was a problem hiding this comment.
Settings.hasSeenInitialOnboardingBefore can we avoid the == true?
Also does this logic apply when the new onboarding FF is off?
| .padding(.bottom, 12.0) | ||
| Text(L10n.eacInformationalViewModalDescription) | ||
| .font(size: 15.0, style: .body, weight: .medium) | ||
| .font(size: FeatureFlag.newOnboardingAccountCreation.enabled ? 17.0 : 15, style: .body, weight: FeatureFlag.newOnboardingAccountCreation.enabled ? .regular : .medium) |
There was a problem hiding this comment.
The tex gets cut with the new font on small devices
| Now | Before |
|---|---|
 |
 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
| 📘 Part of: # |
|:---:|
Fixes PCIOS-
Updates the logic around new onboarding and encourage account creation to only show this screen when new onboarding was already show once and we are updating the app.
Also did some changes on the fonts to match the styling on new onboarding title and labels
To test
Checklist
CHANGELOG.mdif necessary.