Skip to content

Conversation

bjtitus
Copy link
Contributor

@bjtitus bjtitus commented Sep 10, 2025

Fixes PCIOS-126

Moves the Bookmarks view inside the Podcast page inside of the tab.

  • The BookmarksListView is embedded inside of a cell within the PodcastViewController table view. I felt that this was a compromise between keeping the functionality and style of the other bookmarks screens and avoiding a larger refactor of the PodcastViewController. It could use it at some point but I don't know that this is the time.
  • The multi-select action bar logic was moved into ActionBarOverlayView and ActionBarView so it could be both used in the BookmarksListView and presented directly (and properly sized and positioned) on PodcastViewController. Since BookmarksListView is being used as a cell and can flow offscreen, the positioning isn't easily possible strictly in SwiftUI.
Simulator Screenshot - iPhone 16 Plus - 2025-09-09 at 20 58 54 Simulator Screenshot - iPhone 16 Plus - 2025-09-09 at 20 59 08 Simulator Screenshot - iPhone 16 Plus - 2025-09-09 at 21 00 06 Simulator Screenshot - iPhone 16 Plus - 2025-09-09 at 22 25 36

Notes

I took a look at updating some of the styling to better match the Episodes tab but I think that can be a follow up to this PR to keep the size on the smaller side. I focused on maintaining complete functionality and trying to make things operate smoothly rather than making any changes to the existing design.

To test

  • Enable the podcastBookmarksInline Feature Flag - I've left it disabled for now as I'm not sure when this will ship and I'd like to have designers take a look first as we may want to unify a few details before launch
  • Use a plus account or enable Paid Plus in the Developer menu
  • Navigate to a Podcast page
  • Tap the "Bookmarks" tab
  • ✅ Ensure the Empty view shows up and works as expected
  • Add bookmarks to a podcast, some with titles
  • Check the bookmarks
  • ✅ Ensure the bookmarks appear
  • Search your bookmarks
  • ✅ Ensure they filter as expected
  • Try selecting podcasts by long tapping and using the various selection options
  • Try editing and deleting bookmarks

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@bjtitus bjtitus added this to the 7.98 milestone Sep 10, 2025
@bjtitus bjtitus requested a review from a team as a code owner September 10, 2025 04:38
@bjtitus bjtitus requested review from danielebogo and removed request for a team September 10, 2025 04:38
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ This PR is larger than 500 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.

Generated by 🚫 Danger

@bjtitus bjtitus changed the title Inline Podcast bookmark tab Inline Podcast Bookmarks tab Sep 10, 2025
Copy link
Contributor

@danielebogo danielebogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@SergioEstevao
Copy link
Contributor

I was testing the bookmarks multi-select actions and it looks they are not being triggered.

Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-09-11.at.13.11.38.mp4

Copy link
Contributor

@SergioEstevao SergioEstevao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comments about multi-select actions

@pocketcasts pocketcasts modified the milestones: 7.98, 7.99 Sep 15, 2025
@pocketcasts
Copy link
Contributor

Version 7.98 has now entered code-freeze, so the milestone of this PR has been updated to 7.99.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants