-
Notifications
You must be signed in to change notification settings - Fork 156
Inline Podcast Bookmarks tab #3479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
…and adopt in overlay + podcast VC
…ies; unify header height logic
…istView in PodcastViewController
…() behind FeatureFlag.podcastBookmarksInline
Generated by 🚫 Danger |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was testing the bookmarks multi-select actions and it looks they are not being triggered. Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-09-11.at.13.11.38.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my comments about multi-select actions
Version |
Fixes PCIOS-126
Moves the Bookmarks view inside the Podcast page inside of the tab.
BookmarksListView
is embedded inside of a cell within thePodcastViewController
table view. I felt that this was a compromise between keeping the functionality and style of the other bookmarks screens and avoiding a larger refactor of thePodcastViewController
. It could use it at some point but I don't know that this is the time.ActionBarOverlayView
andActionBarView
so it could be both used in theBookmarksListView
and presented directly (and properly sized and positioned) onPodcastViewController
. SinceBookmarksListView
is being used as a cell and can flow offscreen, the positioning isn't easily possible strictly in SwiftUI.Notes
I took a look at updating some of the styling to better match the Episodes tab but I think that can be a follow up to this PR to keep the size on the smaller side. I focused on maintaining complete functionality and trying to make things operate smoothly rather than making any changes to the existing design.
To test
podcastBookmarksInline
Feature Flag - I've left it disabled for now as I'm not sure when this will ship and I'd like to have designers take a look first as we may want to unify a few details before launchChecklist
CHANGELOG.md
if necessary.