Remove Pocket sharing service ahead of July 2025 shutdown #43795
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes all core Pocket integration from Jetpack sharing functionality in preparation for Mozilla's Pocket service shutdown on July 8, 2025.
Removes all Pocket-specific CSS, SVG icons, and social widget configurations as part of Phase 2 cleanup ahead of Pocket service shutdown.
Removes remaining Pocket references from classic theme helper social menu components: - Remove Pocket CSS styling rules from social-menu.css - Remove Pocket domain mapping from icon-functions.php social links array Part of Pocket service removal ahead of July 2025 shutdown.
Removes Pocket references from social logos infrastructure and block configurations: - Delete Pocket SVG source file and clean up font codepoints - Remove Pocket symbol from SVG sprite files - Clean up Pocket references from official brand links documentation - Remove "pocket" keyword from sharing buttons block configuration Part of Pocket service removal ahead of July 2025 shutdown.
- Remove Pocket test from AMP support tests that would fail after removal - Graceful degradation: Existing Pocket configurations are automatically hidden - No database migration needed - sharing service logic skips undefined services - Users with Pocket enabled will simply not see the button anymore - Lightweight solution that doesn't impact site performance during upgrades The sharing service architecture already handles missing services gracefully by checking if the service exists before rendering (sharing-service.php:337). Since Pocket class was removed, existing configurations degrade cleanly. Completes Phase 5 of Pocket service removal plan.
Settings Cleanup: - UI automatically removes Pocket from available services (already handled by service removal) - Add prominent discontinuation notice on sharing settings page - Provide alternative "read later" service suggestions (Instapaper, Raindrop.io, Readwise Reader) - Notice shows for users with existing Pocket configurations or until August 2025 Backwards Compatibility: - Sharing service architecture gracefully handles missing services - API endpoints use get_blog_services() which skips undefined services - No Pocket-specific shortcodes or widgets requiring special handling - No deprecated functions needing notices (entire class was cleanly removed) - Existing configurations degrade silently without breaking site functionality Completes Phase 6 and finalizes comprehensive Pocket service removal.
- Delete smart-pocket.png and [email protected] (smart button graphics) - Delete pocket.png and [email protected] (regular button graphics) - These assets are no longer referenced after Pocket service removal - CSS source maps still contain references but will be cleared on next build Completes asset cleanup for Pocket service discontinuation.
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
github-actions
bot
added
[Block] Sharing Buttons
[Block] Sharing Button
[Feature] Extra Sidebar Widgets
[Feature] Sharing
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 🔴 Action required: Please include detailed testing steps, explaining how to test your change, like so: 🔴 Action required: We would recommend that you add a section to the PR description to specify whether this PR includes any changes to data or privacy, like so: Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
github-actions
bot
added
the
[Status] Needs Author Reply
Code Coverage SummaryCoverage changed in 8 files. Only the first 5 are listed here.
Full summary · PHP report · JS report If appropriate, add one of these labels to override the failing coverage check:
Covered by non-unit tests
|
jeherve
reviewed
Jun 6, 2025
| /** | ||
| * Pocket sharing service. | ||
| */ | ||
| class Share_Pocket extends Sharing_Source { |
There was a problem hiding this comment.
Instead of deleting the class altogether, I would recommend leveraging our Deprecated_Sharing_Source class, which will allow you to remove the button for visitors, while still displaying an invitation for site admins to remove the now deprecated service.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Complete removal of the Pocket sharing service from Jetpack ahead of Mozilla's July 8, 2025 shutdown. This comprehensive implementation ensures graceful degradation for existing users while providing clear communication and alternative suggestions.
Test plan
Implementation Details
✅ Phase 1: Core Service Removal
✅ Phase 2: Frontend Assets Cleanup
✅ Phase 3: Theme Integration Cleanup
✅ Phase 4: Assets and Configuration
✅ Phase 5: Testing and Validation
✅ Phase 6: User Experience Considerations
Key Technical Benefits
The implementation ensures a smooth transition when Pocket shuts down, with no broken functionality and clear user guidance for alternatives.