-
Notifications
You must be signed in to change notification settings - Fork 513
feat: add three viewing modes for app specification #557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
stefandevo
wants to merge
4
commits into
AutoMaker-Org:v0.12.0rc
from
stefandevo:feature/specification-visualiser
Closed
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
bf15c7e
feat: add three viewing modes for app specification
stefandevo fe440df
fix: address PR review feedback
stefandevo 9c970e3
fix: convert git+ssh URLs to https in package-lock.json
stefandevo 2cb7b0d
fix: add project name testid to project switcher item
stefandevo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
107 changes: 107 additions & 0 deletions
107
apps/ui/src/components/views/spec-view/components/edit-mode/array-field-editor.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,107 @@ | ||
| import { Plus, X, GripVertical } from 'lucide-react'; | ||
| import { Button } from '@/components/ui/button'; | ||
| import { Input } from '@/components/ui/input'; | ||
| import { Card } from '@/components/ui/card'; | ||
| import { useRef, useState, useEffect } from 'react'; | ||
|
|
||
| interface ArrayFieldEditorProps { | ||
| values: string[]; | ||
| onChange: (values: string[]) => void; | ||
| placeholder?: string; | ||
| addLabel?: string; | ||
| emptyMessage?: string; | ||
| } | ||
|
|
||
| interface ItemWithId { | ||
| id: string; | ||
| value: string; | ||
| } | ||
|
|
||
| function generateId(): string { | ||
| return crypto.randomUUID(); | ||
| } | ||
|
|
||
| export function ArrayFieldEditor({ | ||
| values, | ||
| onChange, | ||
| placeholder = 'Enter value...', | ||
| addLabel = 'Add Item', | ||
| emptyMessage = 'No items added yet.', | ||
| }: ArrayFieldEditorProps) { | ||
| // Track items with stable IDs | ||
| const [items, setItems] = useState<ItemWithId[]>(() => | ||
| values.map((value) => ({ id: generateId(), value })) | ||
| ); | ||
|
|
||
| // Track if we're making an internal change to avoid sync loops | ||
| const isInternalChange = useRef(false); | ||
|
|
||
| // Sync external values to internal items when values change externally | ||
| useEffect(() => { | ||
| if (isInternalChange.current) { | ||
| isInternalChange.current = false; | ||
| return; | ||
| } | ||
|
|
||
| // External change - rebuild items with new IDs | ||
| setItems(values.map((value) => ({ id: generateId(), value }))); | ||
| }, [values]); | ||
|
|
||
| const handleAdd = () => { | ||
| const newItems = [...items, { id: generateId(), value: '' }]; | ||
| setItems(newItems); | ||
| isInternalChange.current = true; | ||
| onChange(newItems.map((item) => item.value)); | ||
| }; | ||
|
|
||
| const handleRemove = (id: string) => { | ||
| const newItems = items.filter((item) => item.id !== id); | ||
| setItems(newItems); | ||
| isInternalChange.current = true; | ||
| onChange(newItems.map((item) => item.value)); | ||
| }; | ||
|
|
||
| const handleChange = (id: string, value: string) => { | ||
| const newItems = items.map((item) => (item.id === id ? { ...item, value } : item)); | ||
| setItems(newItems); | ||
| isInternalChange.current = true; | ||
| onChange(newItems.map((item) => item.value)); | ||
| }; | ||
|
|
||
| return ( | ||
| <div className="space-y-2"> | ||
| {items.length === 0 ? ( | ||
| <p className="text-sm text-muted-foreground py-2">{emptyMessage}</p> | ||
| ) : ( | ||
| <div className="space-y-2"> | ||
| {items.map((item) => ( | ||
| <Card key={item.id} className="p-2"> | ||
| <div className="flex items-center gap-2"> | ||
| <GripVertical className="w-4 h-4 text-muted-foreground shrink-0 cursor-grab" /> | ||
| <Input | ||
| value={item.value} | ||
| onChange={(e) => handleChange(item.id, e.target.value)} | ||
| placeholder={placeholder} | ||
| className="flex-1" | ||
| /> | ||
| <Button | ||
| type="button" | ||
| variant="ghost" | ||
| size="icon" | ||
| onClick={() => handleRemove(item.id)} | ||
| className="shrink-0 text-muted-foreground hover:text-destructive" | ||
| > | ||
| <X className="w-4 h-4" /> | ||
| </Button> | ||
| </div> | ||
| </Card> | ||
| ))} | ||
| </div> | ||
| )} | ||
| <Button type="button" variant="outline" size="sm" onClick={handleAdd} className="gap-1"> | ||
| <Plus className="w-4 h-4" /> | ||
| {addLabel} | ||
| </Button> | ||
| </div> | ||
| ); | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.