Fix array should have items #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced `format_array` function to handle properties of type 'array' in the schema, ensuring they conform to Gen3 specifications. - Updated `construct_props` to apply the new array formatting. - Modified `input_schema.py` to include 'array' as a valid property type. - Enhanced tests to validate the new array property handling in the converter.
- Introduced `type_array_needs_items` method to ensure properties of type 'array' include an 'items' property. - Updated the `RuleValidator` class to call this new validation method during initialization. - Enhanced tests in `test_rule_validator.py` to cover scenarios for arrays with and without 'items' properties, ensuring proper error handling and validation logic. - Added a new property `lipid_species` in `input_example.yml` to test the array validation functionality.
…eamline schema definitions
…tebook - Changed the execution count from 2 to 3 for the relevant code cell. - Replaced the call to `data_file_props_need_data_props()` with `type_array_needs_items()` to align with the updated validation logic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.