Fix prompting login for public pages issue#792
Open
yasima-csiro wants to merge 1 commit intomasterfrom
Open
Conversation
adam-collins
requested changes
Mar 25, 2024
Contributor
adam-collins
left a comment
adam-collins
left a comment
There was a problem hiding this comment.
It is a nice idea but breaks pages that are designed to work with conditional content when logged in. I do not see it present in the test environment or links to the code changes also required to keep the pages working as intended.
| {% endif %} | ||
|
|
||
| security.cas.authenticateOnlyIfLoggedInFilterPattern={{ collectory_authenticate_only_if_logged_in_filter_pattern | default('/public/show/*') }} | ||
| security.cas.authenticateOnlyIfLoggedInFilterPattern={{ collectory_authenticate_only_if_logged_in_filter_pattern | default('') }} |
Contributor
There was a problem hiding this comment.
The removal of /public/show/* breaks the functionality of this page. There is role conditional content and without this pattern it breaks the login button that would otherwise be required to make it work.
| security.cas.logoutUrl={{ auth_base_url }}/cas/logout | ||
| security.cas.uriFilterPattern={{ biocache_hub_uri_filter_pattern | default('/admin/*,/alaAdmin/*,/download/*') }} | ||
| security.cas.authenticateOnlyIfLoggedInFilterPattern={{ biocache_hub_authenticate_only_if_logged_in_filter_pattern | default('/occurrences/*,/explore/your-area,/query,/proxy/download/*,/') }} | ||
| security.cas.authenticateOnlyIfLoggedInFilterPattern={{ biocache_hub_authenticate_only_if_logged_in_filter_pattern | default('/query,/proxy/download/*') }} |
Contributor
There was a problem hiding this comment.
The removal of /occurrences/* breaks the role conditional content of occurrence pages, i.e. club view.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the fix for AtlasOfLivingAustralia/ala-bie-hub#117