Add nix flake#26
Merged
Merged
Conversation
Matches the flake structure used in sem and weave. Closes #9
There was a problem hiding this comment.
inspect review
Triage: 6 entities analyzed | 0 critical, 0 high, 0 medium, 6 low
Verdict: standard_review
Findings (7)
- [low] flake.nix line 28: Variable shadowing bug - 'self' parameter shadows the 'self' from outer scope (line 11), breaking access to the flake's self reference
- [low] flake.nix line 36: Variable shadowing bug - 'pkgs' is redefined in the let binding, shadowing the 'pkgs' parameter from perSystem (line 29), which will cause the parameter to be ignored
- [low] package.nix and shell.nix: Reference to undefined 'rust-bin' - rust-overlay is imported in flake.nix but not available in the standalone package.nix/shell.nix contexts when called with default
- [low] package.nix line 28: 'clang' is redundantly listed in nativeBuildInputs when 'llvmPackages.clang' already provides it, but more critically, clang should not be in nativeBuildInputs for a Rust build - this is a configuration error
- [low] package.nix line 32: 'pkg-config' is incorrectly listed in buildInputs when it should only be in nativeBuildInputs (where it already appears on line 24) - pkg-config is a build tool, not a runtime dependency
- [low] package.nix line 34: Rust toolchain should not be in buildInputs - rustPlatform.buildRustPackage already provides the Rust compiler, adding it here will cause conflicts
- [low] package.nix line 32: pkg-config listed in both nativeBuildInputs and buildInputs, which is incorrect - it should only be in nativeBuildInputs as a build-time tool
Reviewed by inspect | Entity-level triage found 0 high-risk changes
| version = let | ||
| crate_name = pname + "-cli"; | ||
| in | ||
| (builtins.fromTOML (lib.readFile "${src}/crates/${crate_name}/Cargo.toml")).package.version; |
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #9