Skip to content

Added factorial programs #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

srinivasharsha
Copy link

@srinivasharsha srinivasharsha commented Oct 4, 2018

IMPORTANT: Please do not create a Pull Request without creating an issue first.

Any change needs to be discussed before proceeding.

Description

Please describe what changes you have made.

For Example:

  • Added code for factorial program in C/C++/Java/Python

Related Issue

Issue #194

Please link to the issue here: #194

How Has This Been Tested? (Optional)

Ran the codes on command line on macOS 10.13

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • New Program/Algorithm (non-breaking change which adds functionality)

Checklist:

Go over all the following points, and put an x in all the boxes that apply.

If you're unsure about any of these, don't hesitate to ask. We're here to help!

  • My code follows the code style of this project.

  • My change requires a change to the documentation.

  • I have updated the documentation accordingly.

  • I have read the CONTRIBUTING document.

Copy link
Contributor

@GnikDroy GnikDroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are adding to the wrong folder. Please add files to Maths/Factorial

@GnikDroy
Copy link
Contributor

GnikDroy commented Oct 4, 2018

It seems to be a duplicate of #196. We will look at this. We will select the better version as far as possible.

@GnikDroy GnikDroy added duplicate This issue or pull request already exists java c++ Issue is specific to c++ python labels Oct 4, 2018
@GnikDroy GnikDroy dismissed their stale review October 10, 2018 09:48

Changes made

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issue is specific to c++ duplicate This issue or pull request already exists java python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants