v1.3.6 release

[tpcarman]

Description

Fixed

• Fix divide by zero error (@rebelinux) (Fix #129)
• Fix PowerCLI module dependency (#134)
• Update colour placeholders in README.md

Changed

• Improve vSAN Capacity reporting and healthchecks
• Add VCF.PowerCLI to ExternalModuleDependencies in the module manifest.

Removed

• Remove Get-RequiredModule function to check for PowerCLI versions.
• Remove VMware document style script

Related Issue

• Bug - division by zero in space percentage calculations for datastore clusters #129
• Update PowerCLI version #134

Motivation and Context

• Bug fixes

How Has This Been Tested?

• Tested in lab and production environments

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.

[github-actions]

PSScriptAnalyzer results:

Errors: [0], Warnings: [7], Information: [5]

RuleName   : PSUseProcessBlockForPipelineCommand
Severity   : Warning
ScriptName : Get-Uptime.ps1
Line       : 6
Message    : Command accepts pipeline input but has not defined a process block.

RuleName   : PSAvoidOverwritingBuiltInCmdlets
Severity   : Warning
ScriptName : Get-Uptime.ps1
Line       : 1
Message    : 'Get-Uptime' is a cmdlet that is included with PowerShell (version 
             core-6.1.0-windows) whose definition should not be overridden

RuleName   : PSUseProcessBlockForPipelineCommand
Severity   : Warning
ScriptName : Get-License.ps1
Line       : 35
Message    : Command accepts pipeline input but has not defined a process block.

RuleName   : PSUseProcessBlockForPipelineCommand
Severity   : Warning
ScriptName : Get-License.ps1
Line       : 38
Message    : Command accepts pipeline input but has not defined a process block.

RuleName   : PSPossibleIncorrectComparisonWithNull
Severity   : Warning
ScriptName : Get-License.ps1
Line       : 87
Message    : $null should be on the left side of equality comparisons.

RuleName   : PSPossibleIncorrectComparisonWithNull
Severity   : Warning
ScriptName : Get-License.ps1
Line       : 118
Message    : $null should be on the left side of equality comparisons.

RuleName   : PSUseSingularNouns
Severity   : Warning
ScriptName : Get-vCenterStats.ps1
Line       : 1
Message    : The cmdlet 'Get-vCenterStats' uses a plural noun. A singular noun 
             should be used instead.

RuleName   : PSAvoidTrailingWhitespace
Severity   : Information
ScriptName : Get-Uptime.ps1
Line       : 9
Message    : Line has trailing whitespace

RuleName   : PSAvoidTrailingWhitespace
Severity   : Information
ScriptName : Get-PciDeviceDetail.ps1
Line       : 42
Message    : Line has trailing whitespace

RuleName   : PSAvoidTrailingWhitespace
Severity   : Information
ScriptName : Get-PciDeviceDetail.ps1
Line       : 47
Message    : Line has trailing whitespace

RuleName   : PSAvoidTrailingWhitespace
Severity   : Information
ScriptName : Get-PciDeviceDetail.ps1
Line       : 54
Message    : Line has trailing whitespace

RuleName   : PSAvoidTrailingWhitespace
Severity   : Information
ScriptName : Get-PciDeviceDetail.ps1
Line       : 78
Message    : Line has trailing whitespace