Skip to content

fixes broken overlay for in process saves#2880

Open
RaphaelAlvez wants to merge 5 commits intomainfrom
fixes-in-progress-game-title
Open

fixes broken overlay for in process saves#2880
RaphaelAlvez wants to merge 5 commits intomainfrom
fixes-in-progress-game-title

Conversation

@RaphaelAlvez
Copy link
Collaborator

@RaphaelAlvez RaphaelAlvez commented Feb 9, 2026


PR-SERVER-BOT: You can play around with it here: https://test.virtualtabletop.io/PR-2880/pr-test (or any other room on that server)

@96LawDawg 96LawDawg changed the title fixes #2877 fixes broken overlay for in process saves Feb 9, 2026
@96LawDawg
Copy link
Collaborator

Not quite right. It looks like this

This PR

But it originally looked like this

Original

@ArnoldSmith86 ArnoldSmith86 added bug Something isn't working user interface the GUI around the games labels Feb 9, 2026
@RaphaelAlvez
Copy link
Collaborator Author

Not quite right. It looks like this

This PR

But it originally looked like this

Original

done
image

Copy link
Collaborator

@96LawDawg 96LawDawg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is still too much padding. The gray area takes over half the space. Before whatever broke it, the top of the gray area was at the bottom of the letters in FOUR. Can we get it back there?

@ArnoldSmith86
Copy link
Owner

Before whatever broke it, the top of the gray area was at the bottom of the letters in FOUR.

I don't think that's correct. Left is this PR, right is [ad3ee6cc](https://test.virtualtabletop.io/PR-12374/) 2026-02-07 Fix AI imagery notification incorrect on shared games (fixes #2861) (#2862) (so before Raphael decoupled the overlays):

image

There's slightly more padding/margin but it looks fine to me.

In general, I slightly prefer the old alignment on the right but I kinda like how small it is when it's only "similar to" and that should be in the same position for all games:

image

That doesn't really have anything to do with this PR though. This PR seems to fix the visual glitch and make the appearance consistent with the rest of the library.

So, @96LawDawg, if you still think there's a significant difference somewhere, please provide a side-by-side screenshot. 🙂

coding on my phone. let's hope everything is alright
@96LawDawg 96LawDawg dismissed their stale review February 12, 2026 20:44

Changes look good.

Copy link
Collaborator

@96LawDawg 96LawDawg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working user interface the GUI around the games

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants