In a normal zoon star has a similar size in game shelf and in game page#2859
Open
RaphaelAlvez wants to merge 6 commits intomainfrom
Open
In a normal zoon star has a similar size in game shelf and in game page#2859RaphaelAlvez wants to merge 6 commits intomainfrom
RaphaelAlvez wants to merge 6 commits intomainfrom
Conversation
Owner
|
The star should probably always be the same size in proportion to the image underneath? |
Collaborator
Author
Thas what I was aiming for but later I noticed that for the game page there some media queries that intentionally make the star bigger or smaller. also the number thing under the start (what is this for) is broken in this PR |
Owner
Shows the number of rooms the game is starred in.
Yeah, at some point the image is tiny and the star is a touch target. At that point it probably makes sense to make it bigger. 🤷♂️ |
Owner
|
I updated stuff so that the star size is calculated as a fraction of the image. But:
|
18ef573 to
ae6fb99
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before
after
Side bar

full screen

PR-SERVER-BOT: You can play around with it here: https://test.virtualtabletop.io/PR-2859/pr-test (or any other room on that server)