Skip to content

In a normal zoon star has a similar size in game shelf and in game page#2859

Open
RaphaelAlvez wants to merge 6 commits intomainfrom
Consistent-star-icon
Open

In a normal zoon star has a similar size in game shelf and in game page#2859
RaphaelAlvez wants to merge 6 commits intomainfrom
Consistent-star-icon

Conversation

@RaphaelAlvez
Copy link
Collaborator

@RaphaelAlvez RaphaelAlvez commented Feb 6, 2026

Before

Image Image

after

Side bar
image

full screen
image


PR-SERVER-BOT: You can play around with it here: https://test.virtualtabletop.io/PR-2859/pr-test (or any other room on that server)

@ArnoldSmith86
Copy link
Owner

The star should probably always be the same size in proportion to the image underneath?

@ArnoldSmith86 ArnoldSmith86 added enhancement New feature or request user interface the GUI around the games labels Feb 6, 2026
@RaphaelAlvez
Copy link
Collaborator Author

The star should probably always be the same size in proportion to the image underneath?

Thas what I was aiming for but later I noticed that for the game page there some media queries that intentionally make the star bigger or smaller.

also the number thing under the start (what is this for) is broken in this PR

@ArnoldSmith86
Copy link
Owner

what is this for

Shows the number of rooms the game is starred in.

some media queries that intentionally make the star bigger or smaller

Yeah, at some point the image is tiny and the star is a touch target. At that point it probably makes sense to make it bigger. 🤷‍♂️

@ArnoldSmith86
Copy link
Owner

ArnoldSmith86 commented Feb 7, 2026

I updated stuff so that the star size is calculated as a fraction of the image. But:

  • I gotta test if everything is fine with share/link images that use the same space.
  • The star counter text isn't pretty yet.
  • For the smallest viewport, the star should be bigger again.

@ArnoldSmith86 ArnoldSmith86 linked an issue Feb 8, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request user interface the GUI around the games

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Star icon is bigger when you open the game

2 participants