Skip to content

refactor: remove unused get bytes transaction method #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ItsANameToo merged 1 commit into from
Apr 2, 2025
Merged

refactor: remove unused get bytes transaction method #157

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions crypto/transactions/serializer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,6 @@ def __init__(self, transaction: AbstractTransaction):
def new(transaction: AbstractTransaction):
return Serializer(transaction)

@staticmethod
def get_bytes(transaction: AbstractTransaction, skip_signature: bool = False) -> bytes:
return transaction.serialize(skip_signature=skip_signature)

def serialize(self, skip_signature: bool = False) -> bytes:
transaction_hash = TransactionUtils.to_buffer(self.transaction.data, skip_signature=skip_signature).decode()

Expand Down
5 changes: 0 additions & 5 deletions crypto/transactions/types/abstract_transaction.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,6 @@ def refresh_payload_data(self):
def get_id(self) -> str:
return TransactionUtils.get_id(self.data)

def get_bytes(self, skip_signature: bool = False) -> bytes:
from crypto.transactions.serializer import Serializer

return Serializer.get_bytes(self, skip_signature)

def sign(self, private_key: PrivateKey):
transaction_hash = TransactionUtils.to_buffer(self.data, skip_signature=True).decode()

Expand Down
5 changes: 0 additions & 5 deletions tests/transactions/test_transaction.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,6 @@ def test_verify_transaction(load_transaction_fixture):
transaction = Deserializer.new(load_transaction_fixture('transfer')['serialized']).deserialize()
assert transaction.verify()

def test_transaction_to_bytes(load_transaction_fixture):
transaction = Deserializer.new(load_transaction_fixture('transfer')['serialized']).deserialize()
actual = transaction.get_bytes()
assert isinstance(actual, bytes)

def test_transaction_to_array(load_transaction_fixture):
transaction = Deserializer.new(load_transaction_fixture('transfer')['serialized']).deserialize()
actual = transaction.to_dict()
Expand Down