Skip to content

Conversation

@alexbarnsley
Copy link
Member

@alexbarnsley alexbarnsley commented Feb 19, 2025

Summary

https://app.clickup.com/t/86dw1cxnq
https://app.clickup.com/t/86dw15f4f

  • Updates Fixtures for transactions & identities
  • Removes unused and undocumented crypto.transactions.Transaction class
  • Updates hashing from sha256 to keccak256
  • Fixes issues with trimming "0x" from the left of data - potentially causes issues whereby "0x0123" would become "123"
  • Handles deserializing transactions outside of the consensus contract
  • General tidying up & test updates

TODO:

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@alexbarnsley alexbarnsley marked this pull request as ready for review February 20, 2025 15:30
@alexbarnsley alexbarnsley mentioned this pull request Feb 21, 2025
4 tasks
@ItsANameToo ItsANameToo merged commit d677d82 into feat/mainsail Feb 21, 2025
8 checks passed
@ItsANameToo ItsANameToo deleted the refactor/keccak-adjustments branch February 21, 2025 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants