Indicate that STORAGES configuration may have more keys
#640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnthagen
changed the title
STORAGES configuration may have more keys
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When porting to django-dbbackup 5.0.0 and moving away from the deprecated
DBBACKUP_STORAGEsettings (#609), I went to the docs and didn't realize that addingSTORAGESwould override the Django defaults:https://docs.djangoproject.com/en/5.2/ref/settings/#storages
This broke the
staticfiles.I think hinting that there could be more to this in the our docs (similar to
INSTALLED_APPS) could help key people in to this detail.Checklist
Please update this checklist as you complete each item:
By submitting this pull request I agree that all contributions comply with this project's open source license(s).