feat: Modern API with validation and improved naming (v2.0.0)

[petre-c]

Summary

• Fixed NuGet package structure to bundle BankIntegrationTypes DLL without listing it as a dependency
• Introduced modern API with validation and better naming
• Version bumped to 2.0.0 (major release due to breaking changes)

BREAKING CHANGES

• TransferTypeRecordSpecific renamed to BankTransferCommonDetails
• Removed CreateGeorgian methods that auto-prefixed "GE" to IBANs

Problem

The generated NuGet package was listing AppifySheets.Immutable.BankIntegrationTypes as a dependency even though the DLL was bundled inside the package. This caused restore failures in consuming projects.

Solution

Added PrivateAssets="all" to the ProjectReference to prevent it from being listed as a NuGet dependency while still bundling the DLL.

API Improvements

New value object types with validation:

• Iban - Validates IBAN format, length, and structure
• Currency - Validates ISO 4217 3-letter currency codes
• BankAccount - Combines IBAN and currency with validation

Better naming:

• TransferTypeRecordSpecific → BankTransferCommonDetails
• Removed confusing CreateGeorgian methods that auto-prefixed "GE"

Factory methods with Result pattern:

// Old style
var credentials = new TBCApiCredentials("user", "pass");

// New style with validation
var credentialsResult = TBCApiCredentials.Create("user", "pass");
if (credentialsResult.IsFailure)
    return credentialsResult.Error;

Migration Guide

1. Replace TransferTypeRecordSpecific with BankTransferCommonDetails in your code
2. Consider migrating to new types:
   • BankAccountV → Iban
   • CurrencyV → Currency
   • BankAccountWithCurrencyV → BankAccount
3. Original types are marked as [Obsolete] but still functional

Test Plan

• Solution builds without errors
• All tests pass
• NuGet package bundles DLL correctly
• Demo and test projects updated to use new API

Collaboration by Claude