Skip to content

Fix sliding rail crashes when water interacts with blocks that cannot be waterlogged, fix update range of activator sliding rail. 修复滑轨与水和不能含水方块特定条件交互下崩档，修正激活滑轨更新范围。 #3298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Gu-ZT merged 7 commits into from
Feb 16, 2026
Merged

Fix sliding rail crashes when water interacts with blocks that cannot be waterlogged, fix update range of activator sliding rail. 修复滑轨与水和不能含水方块特定条件交互下崩档，修正激活滑轨更新范围。 #3298

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5657f74
Merge pull request #1 from Anvil-Dev/releases/1.21/1.5
alpha-hhh Jan 13, 2026
a323a8f
Revert "1、修复进入世界时下降沿脉冲发生器无更新的情况下第一次无响应的问题"
alpha-hhh Jan 15, 2026
1a2ed55
Merge pull request #2 from Anvil-Dev/releases/1.21/1.5
alpha-hhh Feb 4, 2026
e035f06
1
alpha-hhh Feb 4, 2026
ca79adb
Merge branch 'test/1.21-1.5' into test/1.21/1.5
alpha-hhh Feb 4, 2026
27eb0b0
激活滑轨上方可充能方块的五个方向能被正确更新了
alpha-hhh Feb 14, 2026
1aaa2dc
原样
alpha-hhh Feb 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/main/java/dev/dubhe/anvilcraft/api/sliding/SlidingBlockSection.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,8 @@ public void setBlock(Level level, BlockPos center, Entity entity) {
Block.dropResources(state, level, pos);
continue;
}
if (level.getFluidState(pos).getType() == Fluids.WATER) {
if (level.getFluidState(pos).getType() == Fluids.WATER
&& state.hasProperty(BlockStateProperties.WATERLOGGED)) {
state = state.setValue(BlockStateProperties.WATERLOGGED, true);
}

Expand Down
12 changes: 8 additions & 4 deletions src/main/java/dev/dubhe/anvilcraft/block/sliding/ActivatorSlidingRailBlock.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,8 @@
public class ActivatorSlidingRailBlock extends BaseSlidingRailBlock implements IHammerChangeable, IMoveableEntityBlock {
public static final List<Direction> SIGNAL_SOURCE_SIDES = List.of(
Direction.DOWN, Direction.NORTH, Direction.SOUTH, Direction.EAST, Direction.WEST);
public static final List<Direction> UPDATE_SIDES = List.of(
Direction.UP, Direction.NORTH, Direction.SOUTH, Direction.EAST, Direction.WEST);
public static final VoxelShape AABB_X = Stream.of(
Block.box(0, 0, 0, 16, 6, 16),
Block.box(0, 6, 11, 16, 16, 16),
Expand Down Expand Up @@ -144,6 +146,7 @@ protected void updatePower(Level level, BlockPos pos, BlockState state, BlockPos
boolean shouldPower = this.isPowered(level, pos);
if (powered != shouldPower) {
level.setBlockAndUpdate(pos, state.setValue(POWERED, shouldPower));
this.updateAbove(level, pos);
}
if (powered) {
Direction.Axis axis = state.getValue(FACING).getAxis();
Expand Down Expand Up @@ -292,10 +295,11 @@ private void updateAbove(Level level, BlockPos pos) {
aboveState.onNeighborChange(level, abovePos, pos);
level.neighborChanged(aboveState, abovePos, this, pos, false);
if (!aboveState.isRedstoneConductor(level, abovePos)) return;
abovePos = abovePos.above();
aboveState = level.getBlockState(abovePos);
if (!aboveState.getWeakChanges(level, abovePos)) return;
level.neighborChanged(aboveState, abovePos, this, pos, false);
for (Direction dir : UPDATE_SIDES) {
BlockPos neighborPos = abovePos.relative(dir);
BlockState neighborState = level.getBlockState(neighborPos);
level.neighborChanged(neighborState, neighborPos, aboveState.getBlock(), abovePos, false);
}
}

@Override
Expand Down