Skip to content

Fix: Use default_factory for splits and make char fields optional in DatasetConstants #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: Use default_factory for splits and make char fields optional in DatasetConstants #219

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/convert_dataset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
import platform
import warnings
from argparse import ArgumentParser, Namespace
from dataclasses import dataclass
from dataclasses import dataclass, field
from enum import Enum
from typing import Dict, Iterable, Optional, Union

Expand Down Expand Up @@ -72,9 +72,9 @@ class DataSplitConstants:

@dataclass
class DatasetConstants:
chars_per_sample: int
chars_per_token: int
splits = {}
chars_per_sample: Optional[int] = None
chars_per_token: Optional[int] = None
splits: dict[str, DataSplitConstants] = field(default_factory=dict)

def __iter__(self):
for _, v in self.splits.items():
Expand Down