Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds GitHub Actions for CI/CD build automation while performing code cleanup for signal disconnection and removing an unused autoload. The purpose is to establish automated builds for debug versions of the Godot project on both Linux and Windows platforms.
- Adds GitHub Actions workflow for automated debug builds on Linux and Windows
- Implements proper signal disconnection in
_exit_tree()methods across menu components - Removes unused MenuMusic autoload and associated scene file
Reviewed Changes
Copilot reviewed 10 out of 13 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/build_debug.yml |
New GitHub Actions workflow for automated debug builds |
project.godot |
Removes MenuMusic autoload configuration |
autoloads/menu_music.tscn |
Deletes unused menu music scene file |
menus/main_menu.gd |
Adds signal disconnection and comments out incomplete scene transition |
menus/options/sound/*.gd |
Adds proper signal disconnection in audio control scripts |
menus/credits/*.gd |
Adds signal disconnection for button components |
menus/options/screen/screen_mode_button.gd |
Removes outdated comments |
| export DATE=$(date +'%Y-%m-%d') | ||
| echo "DATE=$DATE" >> $GITHUB_ENV | ||
| echo "MAIN_FOLDER=$(pwd)" >> $GITHUB_ENV | ||
| echo "JOB_TARGET='Both'" >> $GITHUB_ENV |
There was a problem hiding this comment.
The JOB_TARGET is hardcoded to 'Both' but should use the workflow input parameter. Change to: echo "JOB_TARGET=${{ github.event.inputs.job_target || 'Both' }}" >> $GITHUB_ENV
| echo "JOB_TARGET='Both'" >> $GITHUB_ENV | |
| echo "JOB_TARGET=${{ github.event.inputs.job_target || 'Both' }}" >> $GITHUB_ENV |
.github/workflows/build_debug.yml
Outdated
| mkdir -p ${{ env.EXPORT_FOLDER_LINUX }} | ||
| ./Godot_v${{ env.GODOT_VERSION }}-stable_linux.x86_64 --import ${{ env.GODOT_PROJECT_LOCATION }} --quiet --headless --export-debug --verbose Linux ${{ env.MAIN_FOLDER }}/${{ env.EXPORT_FOLDER_LINUX }}/${{ env.APPLICATION_NAME }}.x86_64 --verbose | ||
| chmod +x ${{ env.EXPORT_FOLDER_LINUX }}/${{ env.APPLICATION_NAME }}.sh --verbose | ||
| chmod +x ${{ env.EXPORT_FOLDER_LINUX }}/${{ env.APPLICATION_NAME }}.86_64 --verbose |
There was a problem hiding this comment.
The --verbose flag is incorrectly placed after the filename. It should be: chmod +x ${{ env.EXPORT_FOLDER_LINUX }}/${{ env.APPLICATION_NAME }}.sh
| chmod +x ${{ env.EXPORT_FOLDER_LINUX }}/${{ env.APPLICATION_NAME }}.86_64 --verbose | |
| chmod +x --verbose ${{ env.EXPORT_FOLDER_LINUX }}/${{ env.APPLICATION_NAME }}.sh | |
| chmod +x --verbose ${{ env.EXPORT_FOLDER_LINUX }}/${{ env.APPLICATION_NAME }}.86_64 |
.github/workflows/build_debug.yml
Outdated
| mkdir -p ${{ env.EXPORT_FOLDER_LINUX }} | ||
| ./Godot_v${{ env.GODOT_VERSION }}-stable_linux.x86_64 --import ${{ env.GODOT_PROJECT_LOCATION }} --quiet --headless --export-debug --verbose Linux ${{ env.MAIN_FOLDER }}/${{ env.EXPORT_FOLDER_LINUX }}/${{ env.APPLICATION_NAME }}.x86_64 --verbose | ||
| chmod +x ${{ env.EXPORT_FOLDER_LINUX }}/${{ env.APPLICATION_NAME }}.sh --verbose | ||
| chmod +x ${{ env.EXPORT_FOLDER_LINUX }}/${{ env.APPLICATION_NAME }}.86_64 --verbose |
There was a problem hiding this comment.
The filename appears to be missing the 'x' character and has incorrect --verbose placement. Should be: chmod +x ${{ env.EXPORT_FOLDER_LINUX }}/${{ env.APPLICATION_NAME }}.x86_64
| chmod +x ${{ env.EXPORT_FOLDER_LINUX }}/${{ env.APPLICATION_NAME }}.86_64 --verbose | |
| chmod +x ${{ env.EXPORT_FOLDER_LINUX }}/${{ env.APPLICATION_NAME }}.x86_64 |
.github/workflows/build_debug.yml
Outdated
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: ${{ env.APPLICATION_NAME }}_linux_debug_$${{ env.DATE }}.tar | ||
| path: ${{ env.APPLICATION_NAME }}_linux_debug_$${{ env.DATE }}.tar |
There was a problem hiding this comment.
Double dollar sign in template expression will cause incorrect variable expansion. Should be: name: ${{ env.APPLICATION_NAME }}linux_debug${{ env.DATE }}.tar
| path: ${{ env.APPLICATION_NAME }}_linux_debug_$${{ env.DATE }}.tar | |
| name: ${{ env.APPLICATION_NAME }}_linux_debug_${{ env.DATE }}.tar | |
| path: ${{ env.APPLICATION_NAME }}_linux_debug_${{ env.DATE }}.tar |
.github/workflows/build_debug.yml
Outdated
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: ${{ env.APPLICATION_NAME }}_linux_debug_$${{ env.DATE }}.tar | ||
| path: ${{ env.APPLICATION_NAME }}_linux_debug_$${{ env.DATE }}.tar |
There was a problem hiding this comment.
Double dollar sign in template expression will cause incorrect variable expansion. Should be: path: ${{ env.APPLICATION_NAME }}linux_debug${{ env.DATE }}.tar
| path: ${{ env.APPLICATION_NAME }}_linux_debug_$${{ env.DATE }}.tar | |
| name: ${{ env.APPLICATION_NAME }}_linux_debug_${{ env.DATE }}.tar | |
| path: ${{ env.APPLICATION_NAME }}_linux_debug_${{ env.DATE }}.tar |
.github/workflows/build_debug.yml
Outdated
| - name: Uploading GDExtension Windows artifact debug | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: ${{ env.APPLICATION_NAME }}_windows_debug_$${{ env.DATE }} |
There was a problem hiding this comment.
Double dollar sign in template expression will cause incorrect variable expansion. Should be: name: ${{ env.APPLICATION_NAME }}windows_debug${{ env.DATE }}
| name: ${{ env.APPLICATION_NAME }}_windows_debug_$${{ env.DATE }} | |
| name: ${{ env.APPLICATION_NAME }}_windows_debug_${{ env.DATE }} |
| elif index == 1: # Windowed | ||
| DisplayServer.window_set_mode(DisplayServer.WINDOW_MODE_FULLSCREEN) No newline at end of file | ||
| elif index == 1: | ||
| DisplayServer.window_set_mode(DisplayServer.WINDOW_MODE_FULLSCREEN) |
There was a problem hiding this comment.
The window mode logic is reversed. Index 0 should set fullscreen mode, but it's setting windowed mode. The logic for indices 0 and 1 should be swapped.
c436f63 to
b3de4cd
Compare
No description provided.