Skip to content

Reject SPSA int params with C < 0.50 during workload validation #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yohaann196 wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Reject SPSA int params with C < 0.50 during workload validation #320

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c2e34e1
Fix datatype validation and update assertions
yohaann196 Apr 5, 2026
b38d72c
Update OpenBench/workloads/verify_workload.py
yohaann196 Apr 5, 2026
1a5c94d
Update OpenBench/workloads/verify_workload.py
yohaann196 Apr 5, 2026
a8906d7
Replace bare except with except Exception in fetch_artifact_url
Copilot Apr 5, 2026
5604bd7
Merge pull request #1 from yohaann196/yohaann196-patch-1
yohaann196 Apr 5, 2026
00d0d37
Update verify_workload.py
yohaann196 Apr 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions OpenBench/workloads/verify_workload.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,7 +313,7 @@ def verify_spsa_inputs(errors, request, field):
name, data_type, value, minimum, maximum, c, r = line.split(',')

if data_type.strip() not in [ 'int', 'float' ]:
errors.append('Datatype must be int for float, for %s' % (name))
errors.append('Datatype must be int or float, for %s' % (name))

if float(minimum) > float(maximum):
errors.append('Max does not exceed Min, for %s' % (name))
Expand All @@ -324,6 +324,9 @@ def verify_spsa_inputs(errors, request, field):
if data_type.strip() == 'float' and float(c) <= 0.00:
errors.append('C for floats must be > 0.00, for %s' % (name))

if data_type.strip() == 'int' and float(c) < 0.50:
errors.append('C for ints must be >= 0.50, for %s' % (name))

if float(r) <= 0.00:
errors.append('R must be > 0.00, for %s' % (name))

Expand Down Expand Up @@ -501,4 +504,4 @@ def fetch_artifact_url(base, engine, headers, sha):

except Exception as error:
# If anything goes wrong, retry later with the same base URL
return (base, False)
return (base, False)