fix: tui quote handling#44
Merged
Merged
Conversation
- Add `tui_split()` that only treats double quotes as grouping, so
apostrophes in natural language (e.g. "l'arrondissement") no longer
silently fail via `shlex.split` `ValueError`
- Use `shlex.quote()` in `convert_args_to_dict()` instead of manual
`f"'{x}'"` wrapping, which broke on values containing single quotes
- Forward `*args` through `ShowTuiError` so `--tui` flag preserves
command arguments as initial TUI input
`TuiCli.run()` used `shlex.join()` which produces single-quote based quoting, but `tui_split()` only treats double quotes as grouping. This broke the round-trip for args containing spaces or apostrophes. - Add `tui_join()` that double-quotes args with spaces, matching `tui_split()`'s double-quote-only parsing - Replace `shlex.join()` in `TuiCli.run()` with `tui_join()` - Add round-trip tests for `tui_join`/`tui_split`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.