update to 2.12.0 #15
Merged
update to 2.12.0 #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Linter check found the following problems:ERROR conda.cli.main_run:execute(124): `conda run conda-lint /tmp/abs_31prcxo6j0/clone` failed. (See above for error) The following problems have been found:===== ERRORS =====
|
Linter check found the following problems:ERROR conda.cli.main_run:execute(124): `conda run conda-lint /tmp/abs_18jg6dz0e6/clone` failed. (See above for error) The following problems have been found:===== ERRORS =====
|
Linter check found the following problems:ERROR conda.cli.main_run:execute(124): `conda run conda-lint /tmp/abs_c2b3q5i56r/clone` failed. (See above for error) The following problems have been found:===== ERRORS =====
|
Linter check found the following problems:ERROR conda.cli.main_run:execute(124): `conda run conda-lint /tmp/abs_2el81t7jw0/clone` failed. (See above for error) The following problems have been found:===== ERRORS =====
|
Jrice1317
reviewed
Apr 2, 2024
| {% set abi_buildnumber = "1" %} | ||
| # pybind11 now defines two ABI version. 4 and 5 for 3.12+ or msvc. | ||
| # https://github.com/pybind/pybind11/blob/v2.12.0/include/pybind11/detail/internals.h#L40 | ||
| {% set abi_version = "4" %} # [py<312 and not win] |
There was a problem hiding this comment.
I see the requirement that version 5 is used for py>=312 but I can't seem to find anything related to win being affected or not. Can you please point me in the right direction?
There was a problem hiding this comment.
This line has defined(_MSC_VER). (which can be read as if visual studio).
And the details are in this PR: pybind/pybind11#4779
There was a problem hiding this comment.
@Jrice1317 In case you wonder, _MSC_VER is documented in https://learn.microsoft.com/en-us/cpp/preprocessor/predefined-macros?view=msvc-170.
boldorider4
reviewed
Apr 3, 2024
| # pybind11 now defines two ABI version. 4 and 5 for 3.12+ or msvc. | ||
| # https://github.com/pybind/pybind11/blob/v2.12.0/include/pybind11/detail/internals.h#L40 | ||
| {% set abi_version = "4" %} # [py<312 and not win] | ||
| {% set abi_buildnumber = "1" %} # [py<312 and not win] |
There was a problem hiding this comment.
where does abi_buildnumber come from?
There was a problem hiding this comment.
It's just the build number of the pybind11-abi package (line 28).
JeanChristopheMorinPerso
approved these changes
Apr 3, 2024
There was a problem hiding this comment.
LGTM! From conda-forge#95, it looks like conda-forge will potentially also change their pybind11-abi version to 5 for py312 and windows.
Linter check found the following problems:ERROR conda.cli.main_run:execute(124): `conda run conda-lint /tmp/abs_cfy744ih9k/clone` failed. (See above for error) The following problems have been found:===== ERRORS =====
|
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
https://github.com/pybind/pybind11/tree/v2.12.0
Note:
pybind11 now defines two ABI version. 4 and 5 for 3.12+ or msvc.
https://github.com/pybind/pybind11/blob/v2.12.0/include/pybind11/detail/internals.h#L40
pybind11-abi is used only by libmambapy (which will require a rebuild).