Repository navigation
Support both log depth buffer defines across three.js versions - #15
Merged
Merged
Conversation
Ameobea
approved these changes
Aug 6, 2026
Owner
|
Looks great - thanks for another very helpful contribution. |
Owner
|
This fix is deployed in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three.js renamed the USE_LOGDEPTHBUF shader define to USE_LOGARITHMIC_DEPTH_BUFFER in r180. Since this library's peer dependency range spans both sides of that change (>= 0.125.0 <= 0.182.0), the log-depth un-linearization in the shaders silently stopped working on r180+.
This PR makes the depth-unlinearization checks in godrays.frag and compositor.frag accept both macro names:
#if defined( USE_LOGDEPTHBUF ) || defined( USE_LOGARITHMIC_DEPTH_BUFFER )