Skip to content

Added support for add column and drop column #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

subkanthi
Copy link
Collaborator

@subkanthi subkanthi commented Jun 30, 2025

closes: #39

@subkanthi subkanthi linked an issue Jun 30, 2025 that may be closed by this pull request
Types.NestedField field;

switch (type.toLowerCase()) {
case "string":
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couldn't find any mapper from string to iceberg Types

return new ColumnSpec(columnName, field.type(), comment);
}

private static Types.NestedField parseColumnType(String name, String type, String comment) {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe this needs to be moved to a common class for field mapping.

@subkanthi subkanthi marked this pull request as ready for review July 1, 2025 21:14
Copy link
Collaborator

@shyiko shyiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should go with @aadant's proposal #39 (comment). Separate add-column/delete-column commands instead of single alter-table means you can't combine multiple changes in a single transactions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a column to an existing table
2 participants