Skip to content

Added support for add column and drop column #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Added support for add column and drop column #41

wants to merge 9 commits into from

Conversation

subkanthi
Copy link
Collaborator

@subkanthi subkanthi commented Jun 30, 2025 •
edited
Loading

closes: #39

@subkanthi subkanthi linked an issue Jun 30, 2025 that may be closed by this pull request
Add a column to an existing table #39
Open
subkanthi
subkanthi commented Jul 1, 2025
View reviewed changes
ice/src/main/java/com/altinity/ice/cli/internal/cmd/AddColumn.java Outdated
Types.NestedField field;

switch (type.toLowerCase()) {
case "string":
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couldn't find any mapper from string to iceberg Types

subkanthi
subkanthi commented Jul 1, 2025
View reviewed changes
ice/src/main/java/com/altinity/ice/cli/internal/cmd/AddColumn.java Outdated
return new ColumnSpec(columnName, field.type(), comment);
}

private static Types.NestedField parseColumnType(String name, String type, String comment) {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe this needs to be moved to a common class for field mapping.

@subkanthi subkanthi marked this pull request as ready for review July 1, 2025 21:14
shyiko
shyiko requested changes Jul 8, 2025
View reviewed changes
Copy link
Collaborator

@shyiko shyiko left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should go with @aadant's proposal #39 (comment). Separate add-column/delete-column commands instead of single alter-table means you can't combine multiple changes in a single transaction.

@subkanthi
Copy link
Collaborator Author 

alter-table flowers.iris --operations '[{"drop": "age"}]'
2025-07-10 15:41:35 [main] INFO c.a.i.c.i.cmd.AlterTable > Dropping column 'age' from table: flowers.iris
2025-07-10 15:41:36 [main] INFO c.a.i.c.i.cmd.AlterTable > Successfully applied 1 operations to table: flowers.iris

Invalid operation

alter-table flowers.iris --operations '[{"rename": "age"}]'
2025-07-10 15:54:17 [main] ERROR com.altinity.ice.cli.Main > Fatal
java.lang.IllegalArgumentException: Invalid operation. Supported operations: add, drop
        at com.altinity.ice.cli.internal.cmd.AlterTable.validateOperation(AlterTable.java:117)
        at com.altinity.ice.cli.internal.cmd.AlterTable.run(AlterTable.java:65)
        at com.altinity.ice.cli.Main.alterTable(Main.java:459)
        at com.altinity.ice.cli.Main.lambda$main$0(Main.java:551) [9 skipped]
        at com.altinity.ice.cli.Main.main(Main.java:558) [1 skipped]

@subkanthi subkanthi requested a review from shyiko July 11, 2025 15:11
shyiko
shyiko reviewed Jul 11, 2025
View reviewed changes
ice/src/main/java/com/altinity/ice/cli/Main.java Outdated
names = {"--operations"},
required = true,
description =
"JSON array of operations: [{'add': 'age:int:User age'}, {'drop': 'col_name'}]")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be best to stick to yaml/json for this as column names may contain colons, future operations may not be so easy to express in colon-separated values, etc.

It would also be nice if operation/files names would follow https://iceberg.apache.org/docs/latest/spark-ddl/#alter-table-rename-column naming.

Copy link
Collaborator Author

@subkanthi subkanthi Jul 16, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

alter-table flowers.iris --operations '[{"operation": "add column", "column_name": "age", "type": "int", "comment": "user age"}]'
2025-07-16 16:12:24 [main] INFO c.a.i.c.i.cmd.AlterTable > Adding column 'age' to table: flowers.iris
2025-07-16 16:12:24 [main] INFO c.a.i.c.i.cmd.AlterTable > Successfully applied 1 operations to table: flowers.iris

 ice alter-table flowers.iris --operations '[{"operation": "drop column", "column_name": "age"}]'
2025-07-16 16:12:48 [main] INFO c.a.i.c.i.cmd.AlterTable > Dropping column 'age' from table: flowers.iris
2025-07-16 16:12:49 [main] INFO c.a.i.c.i.cmd.AlterTable > Successfully applied 1 operations to table: flowers.iris

alter-table flowers.iris --operations '[{"operation": "drop column", "column_name": "age"}, {"operation": "add column", "column_name": "marital_status", "type": "string", "comment": "Marital Status"}]'
2025-07-16 16:35:47 [main] INFO c.a.i.c.i.cmd.AlterTable > Dropping column 'age' from table: flowers.iris
2025-07-16 16:35:47 [main] INFO c.a.i.c.i.cmd.AlterTable > Adding column 'marital_status' to table: flowers.iris
2025-07-16 16:35:47 [main] INFO c.a.i.c.i.cmd.AlterTable > Successfully applied 2 operations to table: flowers.iris

@subkanthi subkanthi requested a review from shyiko July 16, 2025 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shyiko shyiko Awaiting requested review from shyiko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a column to an existing table
2 participants
@subkanthi @shyiko