Antalya 25.6.5: Expose IcebergS3 partition_key and sorting_key in system.tables #959
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zvonand
changed the title
zvonand
force-pushed
the
improvement/antalya/874
branch
2 times, most recently
from
099c984 to
f55dd06
Compare
ianton-ru
reviewed
Aug 18, 2025
src/Storages/ObjectStorage/DataLakes/Iceberg/IcebergMetadata.cpp
Outdated
Show resolved
Hide resolved
| if (!schemas) | ||
| return map; | ||
|
|
||
| for (size_t i = 0; i < schemas->size(); ++i) |
There was a problem hiding this comment.
for (const auto & schema : *schemas)
{
if (!schema->has("schema-id"))
....
and the same way in other cycles over JSON::Array
There was a problem hiding this comment.
Does not look any better: in range-based loop, type will be wrong and will need to be converted explicitly later. This will not be better than it is already:
for (const auto & v : *schemas)
{
const auto & schema = v.extract<Poco::JSON::Object::Ptr>();| String result; | ||
| if (base == "identity") | ||
| result = col; | ||
| else if (base == "year" || base == "month" || base == "day" || base == "hour") |
There was a problem hiding this comment.
Am I right that these types can't have param?
If it true, than next block base != "void" make the same.
If it false, than we lost param, is it correct?
There was a problem hiding this comment.
Am I right that these types can't have
param?
Yes, correct
zvonand
force-pushed
the
improvement/antalya/874
branch
from
1d3f892 to
4980ec2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #874.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Expose IcebergS3
partition_keyandsorting_keyinsystem.tablesExclude tests: