-
Notifications
You must be signed in to change notification settings - Fork 134
fix: clamp the output-token reservation against the context window #1196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
1586f59
fix: clamp the output-token reservation against the context window
anandgupta42 8c289cb
fix: mark the clamped-params return line in the upstream-shared reque…
anandgupta42 1f1adba
Merge remote-tracking branch 'origin/main' into codex/pr-1196-merge-r…
anandgupta42 ac3d782
fix(provider): harden output-token budgeting
anandgupta42 01e13a9
Merge remote-tracking branch 'origin/main' into codex/pr-1196-merge-r…
anandgupta42 12180d1
chore(provider): align upstream markers after main sync
anandgupta42 b058876
chore(provider): protect message option integration
anandgupta42 b06207a
fix: count what is actually sent when clamping the output reservation
anandgupta42 3b01975
fix: close the gaps the second review pass found in the clamp
anandgupta42 4304de8
fix(provider): close output budget media bypasses
anandgupta42 8ee9544
Merge updated PR source branch
anandgupta42 9039a17
fix(provider): preserve small-model output budgets
anandgupta42 ab7c907
fix: close final output budget review gaps
anandgupta42 e37b7a9
fix: bound document budget estimation
anandgupta42 ac7346e
fix: reject untrusted PDF metadata amplification
anandgupta42 858c7b1
fix: parse PDF page counts safely
anandgupta42 0eba8f8
Revert "fix: parse PDF page counts safely"
anandgupta42 908be9c
fix: keep PDF budgeting parser-free
anandgupta42 5e04c78
docs: record PR 1196 final review
anandgupta42 c78e1a6
fix: align budgeting with final request shape
anandgupta42 071f4dc
fix: count duplicate instruction fields
anandgupta42 a279303
docs: finalize PR 1196 review record
anandgupta42 aab3dac
fix: enforce final edge-case budgets
anandgupta42 e3ca597
docs: record final PR 1196 edge-case review
anandgupta42 56dbc7e
fix: scale safety margins for small limits
anandgupta42 d663c49
docs: record final small-limit review
anandgupta42 b7cfd65
test: keep processor fixture within request budget
anandgupta42 cedd33a
docs: record final CI fixture review
anandgupta42 d13f784
fix: count system message framing
anandgupta42 a0d7a4a
docs: record final system-framing review
anandgupta42 b2c3a34
Merge remote-tracking branch 'origin/main' into codex/pr-1196-merge-r…
anandgupta42 e475a2d
fix: harden text and media token estimates
anandgupta42 dc24ed0
fix: preserve dense token floors across chunks
anandgupta42 800e3b1
docs: record post-merge review fixes
anandgupta42 856f428
fix: calibrate semantic media estimates
anandgupta42 f8552be
docs: record final media calibration review
anandgupta42 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.