-
Notifications
You must be signed in to change notification settings - Fork 134
feat(workspace): route warehouse tools through the bound workspace's engine #1156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
ralphstodomingo
wants to merge
30
commits into
feat/workspace-engine-sync
Choose a base branch
from
feat/workspace-precedence
base: feat/workspace-engine-sync
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
edd88e5
feat(workspace): route warehouse tools through the bound workspace's …
2f25ec5
test(workspace): cover precedence decisions; share attach's pin parser
bb4db1a
feat(workspace): report once what the workspace now serves
04e5180
fix(workspace): refresh the CLI help snapshot; mark precedence server…
11b1c72
fix(workspace): gate precedence on the pilot flag; route the dbt fall…
2ddcbfe
fix(workspace): say why a dbt-fallback redirect happened and how to i…
139a12e
fix(workspace): let the safety checks outrank the redirect
5de772a
fix(workspace): keep the write confirmation in front of a redirect
95b0e15
fix(workspace): carry the fail-open notice onto the failure paths too
e57a09d
fix(workspace): weigh the dbt fallback before giving up on an unknown…
8def767
fix(workspace): never redirect a caller to a tool it may not call
8588145
fix(workspace): report only the routing that will actually happen
a75f90d
fix(workspace): attribute the engine that is running, not the one on …
fd1f36c
test(workspace): actually exercise a superseded attach
8740567
fix(workspace): attest the running engine without waiting on the attach
a06841c
fix(workspace): describe each tool by its own capability, and correct…
7461752
fix(workspace): confirm the pin against disk before it enables routing
99bdf2d
docs(workspace): stop crediting a notification that was not published
5de539e
fix(workspace): do not let a routing decision outlive its binding
2a017ab
fix(workspace): say when routing stops, not only when it changes
57d67b3
fix(workspace): only tell a session routing stopped if it was routing
73034ac
fix(connections): pin the fallback connection before the dbt attempt
3468a36
fix(workspace): do not remember an announcement that never arrived
90e4877
fix(workspace): treat a line as said only once it has arrived
ebfc668
fix(connections): bind the fallback to its type, not only its name
bf9f35b
fix(workspace): deliver announcements in the order they were decided
babb2c5
fix(workspace): do not resurrect an evicted session's announcement
6d82419
fix(workspace): compare against the newest line, not the last delivered
c61b1b1
fix(workspace): ask both announcement questions of one record
5034471
test(workspace): assert the invariants rather than samples of them
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When a concurrent
warehouse_addreplaces the same connection name after precedence checks its old, unshadowed config, this lookup resolves the replacement config and can execute a now-workspace-shadowed connection locally, bypassing workspace routing and auditing. Fresh evidence after the prior registry-race finding is that the attempted fix pins only thefallbackNamestring;Registry.get(fallbackName)still consults the mutable registry after the dbt await. Bind the actual selected config/connector or repeat precedence against the connector selected here.Useful? React with 👍 / 👎.