feat: enable aiden-gsuite OAuth setting

[HuangHan96]

No description provided.

[claude]

Claude finished @HuangHan96's task —— View job

---

Code Review Complete ✓

Reviewing PR #350: feat: enable aiden-gsuite OAuth setting

Tasks

• Read repository guidelines (CLAUDE.md if exists)
• Review all changed files
• Check code quality and best practices
• Review security considerations (OAuth implementation)
• Check performance implications
• Verify test coverage
• Review documentation and localization
• Provide inline comments for specific issues
• Summarize findings

---

Summary

This PR enables OAuth support for the aiden-gsuite MCP server. The implementation is straightforward and follows established patterns from existing OAuth integrations (aiden-mail and aiden-outlook).

Changes Overview

1. Added "aiden-gsuite" to OAuth-enabled servers in 3 locations:

   • app/components/setting/mcp-detail.tsx:80
   • app/components/setting/mcp-table-item.tsx:120
   • app/components/setting/mcp-oauth-modal.tsx (via icon mapping)

2. Added Google icon support:

   • New file: app/icons/google.png
   • Import and mapping in mcp-oauth-modal.tsx:41,56

3. Updated localization strings:

   • Changed "Mail Account" → "Account" (more generic)
   • Updated in both en-US and zh-CN locales

---

Code Quality Assessment

✅ Strengths

• Consistency: Changes follow the exact pattern used for existing OAuth providers
• Minimal scope: Only touches necessary files without over-engineering
• Localization: Proper i18n updates in both languages
• UI improvement: Generic "Account" label is more appropriate for non-mail services

⚠️ Areas of Concern

1. Missing Test Coverage

• No tests exist for OAuth functionality
• No tests added for the new aiden-gsuite integration
• Existing test suite only covers model-related functionality

2. Icon Mapping Key Verification Needed (See inline comment on mcp-oauth-modal.tsx:56)

• The mapping uses google: googleIcon (lowercase)
• Other providers use mixed casing (Gmail, QQ, microsoft)
• Action needed: Verify backend returns "google" as the service name, not "Google" or "GSuite"

3. Pre-existing React Hook Issues

• Several useCallback hooks have incomplete dependency arrays
• Not introduced by this PR, but present in modified files
• Could lead to stale closure bugs

4. No PR Description

• Makes it harder to understand context and testing done
• Should include: what was tested, expected behavior, screenshots if applicable

---

Security Review

✅ No security concerns introduced:

• OAuth flow reuses existing secure implementation
• No new authentication logic added
• No hardcoded credentials or sensitive data
• Uses existing addOAuthCredential API from app/services/oauth.ts

The OAuth implementation appears secure:

• Credentials stored via backend API
• Proper HTTP headers with authentication
• No client-side credential exposure

---

Performance Review

✅ No performance concerns:

• Changes are purely conditional logic additions
• useMemo hooks properly used for conditional rendering
• Icon is a small PNG file (~2KB based on similar icons)
• No new API calls or expensive operations

---

Documentation Review

⚠️ Documentation gaps:

• No code comments explaining why these three services need OAuth
• No documentation on how to configure aiden-gsuite OAuth credentials
• No changelog or release notes entry

---

Testing Recommendations

Since no tests exist for OAuth functionality, consider adding:

1. Unit tests for OAuth modal provider rendering
2. Integration tests for OAuth flow with mocked credentials
3. E2E tests for enabling/disabling OAuth-enabled MCP servers

Manual testing checklist (should be verified):

• Enabling aiden-gsuite shows OAuth modal
• Google icon renders correctly in the provider list
• Can add/remove Google accounts successfully
• OAuth credentials persist after page reload
• Works correctly in both light and dark mode
• Localization displays correctly in both languages

---

Recommendations

Before Merge:

1. ✅ Verify icon mapping key - Confirm backend uses "google" (lowercase)
2. 📝 Add PR description - Explain what was tested and how
3. 🧪 Manual testing confirmation - Verify the checklist above

Future Improvements:

1. Add OAuth functionality tests
2. Fix useCallback dependency arrays in these components
3. Document OAuth configuration process
4. Consider adding TypeScript types for provider names to catch mismatches

---

Overall Assessment

Verdict: Approve with minor verification needed ✓

The implementation is solid and follows existing patterns correctly. The only critical item is verifying the icon mapping key matches the backend. Once confirmed, this PR is safe to merge.

The code is clean, consistent, and doesn't introduce any security or performance issues. The lack of tests is a broader codebase issue, not specific to this PR.