Skip to content

Unit test smtp filters #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tkeriven wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Unit test smtp filters #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion app/interface/mail/InterfaceApiMailMailbox.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,6 @@ def purge_mailbox(self, account_id: str, purge_data: dict[str, Any]) -> tuple[di
except RequestException as ex:
logger_api.error("Request exception in purge_mailbox for user %s, account %s: %s", self.user.uid, account_id, str(ex))
return create_api_base_response(None, ex.error)
raise NotImplementedError("Purge mailbox is not implemented yet")


def save_draft(self, account_id: str, mail_data: dict, key: str | None = None) -> tuple[dict, int]:
Expand Down
9 changes: 9 additions & 0 deletions app/manager/mail/ClientSieve.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -667,6 +667,15 @@ def _store_and_activate_script(self, script_name: str, script_content: str,
continue
script_parts_retry.append((section_name, section_content))

# If all parts were skipped, there's nothing left to upload – return skipped sections
if not script_parts_retry:
logger_sieve.info(
"All script parts were skipped after removing unsupported extension '%s'; "
"no script to upload",
missing_capability,
)
return skipped_sections

# If there are still script parts to process, recompile and retry
if script_parts_retry:
try:
Expand Down
Loading
Loading