[PWGHF] Implement TPC pid for light nuclei based on Bethe-Bloch parametrization in HF track skimming task #14729
+161
−46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
changed the title
zhangbiao-phy
changed the title
github-actions
bot
changed the title
zhangbiao-phy
requested review from
NicoleBastid,
alibuild,
apalasciano,
deepathoms,
fcatalan92,
fcolamar,
fgrosa,
gluparel,
hahassan7,
jpxrk,
mfaggin,
mmazzilli,
singhra1994,
stefanopolitano and
vkucera
as code owners
vkucera
requested changes
Feb 1, 2026
Collaborator
Author
|
thanks @vkucera! I fixed your comments now, please take a look. |
vkucera
reviewed
Feb 2, 2026
| return false; | ||
| } | ||
|
|
||
| float itsPidNsigma = -999.f; |
Collaborator
There was a problem hiding this comment.
its is not a quantity, Pid is redundant, Nsigma is not a word.
Suggested change
| float itsPidNsigma = -999.f; | |
| float nSigmaIts = -999.f; |
vkucera
reviewed
Feb 2, 2026
| /// \param lightnuclei Species selector: 0=Deuteron, 1=Triton, 2=Helium3. | ||
| /// \return TPC nσ for the chosen nucleus hypothesis (or -999 if not applicable). | ||
| template <typename TrackType> | ||
| float getTPCnSigmaBB(const TrackType& track, ChannelsNucleiQA lightnuclei) |
Collaborator
There was a problem hiding this comment.
Follow naming conventions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@fgrosa, the BB parametrization is validated with two diffrent analysis of LF