ITS: use faster atan2 for trackleting#14557
Closed
f3sch wants to merge 3 commits intoAliceO2Group:devfrom
Closed
Conversation
Signed-off-by: Felix Schlepper <[email protected]>
Signed-off-by: Felix Schlepper <[email protected]>
Signed-off-by: Felix Schlepper <[email protected]>
Contributor
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of using the full atan2 which is rather expensive one can use a faster approximate method.
The speedup on cpu is around 10% for the trackleting phases (on cpu this is 5% of the total time with 20 threads, so a gain of around 0.5%)
On gpu the speedup is much less 0.5% (prob. within fluctuations, on gpu this phase is around 26% of the total time with <<<30,256>>>, so only 0.13% faster).
The difference in output is minimal (below per-mille). Below is the comparison. The plot in the bottom right shows that after switching with deterministic mode the gpu part still 1:1 reproduces the cpu output.