Add useDataset hook #1462
Merged
Add useDataset hook #1462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
davidsmejia
approved these changes
Sep 8, 2025
client/src/hooks/useDataset.js
Outdated
Comment on lines
20
to
29
| switch (statusCode) { | ||
| case 400: | ||
| case 403: | ||
| case 404: | ||
| case 405: | ||
| case 409: | ||
| return exceptions[statusCode] | ||
| default: | ||
| return defaultMessage | ||
| } |
There was a problem hiding this comment.
Suggested change
| switch (statusCode) { | |
| case 400: | |
| case 403: | |
| case 404: | |
| case 405: | |
| case 409: | |
| return exceptions[statusCode] | |
| default: | |
| return defaultMessage | |
| } | |
| if (statusCode in exceptions) { | |
| return exceptions[statusCode] | |
| } | |
| return defaultMessage | |
I think something like this would be easier to maintain since you already have defined the supported codes.
I don't think we want to be presenting the HTTP errors to the user. For now this is ok but we should have a TODO to handle recoverable errors for now at least.
There was a problem hiding this comment.
Much cleaner using the in operator! I've also added a TODO comment for recoverable error handling.
avrohomgottlieb
approved these changes
Sep 8, 2025
client/src/hooks/useDataset.js
Outdated
|
|
||
| const process = async (dataset) => { | ||
| if (!token) { | ||
| addError('A valid token is required to update the dataset') |
There was a problem hiding this comment.
Suggested change
| addError('A valid token is required to update the dataset') | |
| addError('A valid token is required to process the dataset') |
…set.getErrorMessage and add a TODO comment for recoverable error handling, and fix a typo in useDataset.process
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
Closes #1407
Purpose/Implementation Notes
I've bootstrap the
useDatasethook.Changes include:
useDatasethook with following methods:creategetprocessupdategetErrorMessage: returns a error message that matches the corresponding status code on API request failureTypes of changes
Functional tests
N/A
Checklist
Screenshots
N/A