-
-
Notifications
You must be signed in to change notification settings - Fork 818
Fixed one layout with multiple variant bug hyprland/language Fixes #3676 #4068
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Tested and working great for me. I would recommend also updating the wiki with the following info and example. The "format-{shortDescription}-{variant}" is working fine on my side with the following config: Hyprland config:
Waybar config:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fixes #3676
The opposite has happened here #3224 |
Indeed, however, it does not take into account the case of multiple variants. I will rework it for better detection in both cases: commas in the keyboard name and/or multiple variants |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extract the layout using the parenthesis first THEN the comma,
Since there is no nested parenthesis in a kb layout/variant according to this file:
cat /usr/share/X11/xkb/rules/xorg.xml | grep -E "\(.*\("
Any info on whether this will/can be merged? |
Hypr onfig:
Using find_last_of eg:
ev = "activelayout>>kb-name-,English (US, intl., with dead keys)"
So layout name will be = " with dead keys)" -> unknown layout !
Using find_first_of fixed it.