[1.20.1] Optimise BiomeConfig #5514
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use `Map.entry()` instead of `Pair.of()` as the former tells Java it will never be null and never be changed. - Use `Map.ofEntries()` instead of HashMap for the same reason. Reduces memory usage and improves performance by letting the map be exactly sized and strongly immutable. - Use the deferred class idiom instead of a couple of mutable fields. Allows the map to be stored in a static final and skips the need for an init check. Static finals are faster to load than normal static fields.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Map.entry()instead ofPair.of()as the former tells Java it will never be null and never be changed.Map.ofEntries()instead of HashMap for the same reason. Reduces memory usage and improves performance by letting the map be exactly sized and strongly immutable.